-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call json-utils.js from index.js #468
call json-utils.js from index.js #468
Conversation
move functions used elsewhere from json-utils to a global STREET object
✅ Deploy Preview for 3dstreet-core-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I will also update the function calls from json-utils.js in the Editor repo |
In this PR, all changes are related to requesting json-utils from index.js and calling json-utils functions from the global STREET.utils object. But I also added all corrections to this PR from here (#440) regarding texture saving. Because incorrect saving and loading of textures led to errors on the screen when saving/loading from the Editor. I forgot to mention this. |
@@ -175,7 +178,7 @@ const renameProps = { | |||
intersection: 'not-intersection' | |||
}; | |||
|
|||
function filterJSONstreet (removeProps, renameProps, streetJSON) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this function called from 3dstreet editor? it may cause this error
https://github.com/3DStreet/3dstreet-editor/blob/f763a949ce4cd643573ac7f3f7e321d8bbfa8c6a/src/components/scenegraph/Toolbar.js#L130C26-L130C37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is why this PR should be applied to editor after to prevent that error:
3DStreet/3dstreet-editor#387
changes needed on the editor:
|
move functions used in 3DStreet-editor and in index.html (and another HTMLs) from json-utils to a global
STREET
object