Title and logo in screenshot #409
Conversation
- change tock event function to update - add render call before screenshot - add toggleHelpers function - move takeScreenshotNow function to component
✅ Deploy Preview for 3dstreet-core-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @Algorush great work so far! I'm combining the "hide helpers" ticket feedback here too. On the PR related to that ticket that I closed (since its commit is also in this PR) you wrote:
Yes it's ok, seems to work great!
I don't care what the component name is, but it can't be "screenshot" as that's already reserved for an a-frame component used by the system; might as well keep screentock for now unless there is a need to rename.
Yes, I agree that should be hidden just like the other helper objects.
Thanks, I just merged that and later this week I will do a release for the current version of the Editor repo |
|
From @Algorush
It should just only say "3DStreet" |
|
I added the code to get the logo for the screenshot from the svg element. I used async/await to convert svg format to image. |
| this.el.setAttribute('screentock', 'takeScreenshot', false); | ||
| takeScreenshotNow(this.data.filename, this.data.type, this.data.imgElementSelector); | ||
| } | ||
| this.data.takeScreenshot = false; |
There was a problem hiding this comment.
Hi @Algorush was there any specific reason to change this
this.el.setAttribute('screentock', 'takeScreenshot', false);
into this
this.data.takeScreenshot = false;
In general we're not supposed to do that with a-frame, always using setAttribute so that lifecycle methods / events are properly triggered, but maybe you needed to in this case for some reason?
There was a problem hiding this comment.
through setAttribute the update event is triggered once again. In this case it is not necessary, in other cases it is different. Here takeScreenshot is used only inside the component. I think so, maybe I misunderstand something?
@kfarr Do you mean not to do PR with corrections in 3DStreet-editor yet? Wait a while? |
|
@Algorush yes please do make a correction if possible to the 3dstreet-editor repo through a new PR to master branch. |
|
Now with new release of 3DStreet-editor logo is showing in Editor mode
|
I've done everything so far as part of the
screentockcomponent. Maybe it's better to rename component toscreenshotnow? Since there is no need to use thetockmethod here, as I believe. But maybe there's something I don't know?