Merge pull request #928 from 3DStreet/remove-element-tag-and-class

Remove element tag and class
3DStreet · Nov 19, 2024 · c5a0446 · c5a0446
2 parents 8252e25 + 732df0f
commit c5a0446
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/json-utils_1.1.js b/src/json-utils_1.1.js
@@ -86,7 +86,10 @@ function getElementData(entity) {
 function getAttributes(entity) {
   const elemObj = {};
 
-  elemObj['element'] = entity.tagName.toLowerCase();
+  const tagName = entity.tagName.toLowerCase();
+  if (tagName !== 'a-entity') {
+    elemObj['element'] = tagName;
+  }
 
   if (entity.id) {
     elemObj['id'] = entity.id;
@@ -406,8 +409,8 @@ Add a new entity with a list of components and children (if exists)
  * @return {Element} Entity created
 */
 function createEntityFromObj(entityData, parentEl) {
-  const entity =
-    entityData.entityElement || document.createElement(entityData.element);
+  const tagName = entityData.element || 'a-entity';
+  const entity = entityData.entityElement || document.createElement(tagName);
 
   if (!entity.parentEl && parentEl) {
     parentEl.appendChild(entity);