Merge pull request #711 from 3DStreet/helper-dispose

Dispose helper when removing it
3DStreet · Jul 16, 2024 · 0c0bdb0 · 0c0bdb0
2 parents 3f19531 + 0db4a24
commit 0c0bdb0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/editor/index.js b/src/editor/index.js
@@ -113,7 +113,7 @@ Inspector.prototype = {
       let helper;
 
       if (object instanceof THREE.Camera) {
-        this.cameraHelper = helper = new THREE.CameraHelper(object, 0.1);
+        this.cameraHelper = helper = new THREE.CameraHelper(object);
       } else if (object instanceof THREE.PointLight) {
         helper = new THREE.PointLightHelper(object, 1);
       } else if (object instanceof THREE.DirectionalLight) {
@@ -144,6 +144,7 @@ Inspector.prototype = {
       const helper = this.helpers[node.uuid];
       if (helper) {
         this.sceneHelpers.remove(helper);
+        helper.dispose();
         delete this.helpers[node.uuid];
         Events.emit('helperremove', this.helpers[node.uuid]);
       }