Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: temp_scaler, bp_balance, load_least, #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YouMeiYouMaoTai
Copy link
Contributor

ensure_scaler, ensure_scheduler, lass, pass,
rotate.
and Three types of load plots

Copy link
Collaborator

@ActivePeter ActivePeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

scripts/draw2.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this feature? Can the script's purpose be included in its name? Please also attach the Feishu documentation.

@@ -1,44 +1,93 @@

avg_cnt: 1

## filter with fixed value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link the Introduction in feishu of this yaml

@@ -0,0 +1,131 @@
# 自动运行同路径下的run_different_req_freq.py
import os
CUR_FPATH = os.path.abspath(__file__)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么有一个单独的文件叫draw script,其他的脚本外面还有几个draw脚本,建议直接放到一个层级下

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对应的说明文档在顶上注释链接下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个绘图文件是草稿,忘记删除了

let schedule_able_fns = schedule_helper::collect_task_to_sche(
req,
env,
schedule_helper::CollectTaskConfig::PreAllSched,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre all sched是 pos的核心逻辑,为什么ensure也用的这个

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当时想测试这三种有什么性能上的区别,测完没改回来

}
else {
cur_container_cnt + sqrt_container_cnt
if need_to_schedule || cur_container_cnt == 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当前容器数为0,不需要调度的情况,为什么要走这个逻辑,走了这个逻辑就到==0的case,返回1了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一开始没加这一块,实验跑出来发现冷启动延迟很大,文章中控制缩容的时候还关注了slo,但是在系统实现这两个算法的时候时间比较紧,没有实现这个slo来控制缩容,所以给这块补偿了这个逻辑来尽量接近原来的冷启动情况。


log::info!("fnid:{}, frame:{}, recent_speed:{}", fnid, env.core().current_frame(), recent_speed);

if recent_speed < 0.00001 && need_to_schedule{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里和下面的1000取值都是怎么来的

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是自己论文的话建议飞书里建个文档仔细的介绍下,连接到主页

@@ -88,7 +83,7 @@ impl Scheduler for EnsureScheduler {
let schedule_able_fns = schedule_helper::collect_task_to_sche(
req,
env,
schedule_helper::CollectTaskConfig::PreAllSched,
schedule_helper::CollectTaskConfig::All,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一块确认清楚,尤其是scaler那里和这并不一样,最好引用一下文档,在文档里解释下原文实现和这个的映射

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass的实现怎么是随机,我记得不是静态贪婪嘛

ensure_scaler, ensure_scheduler, lass, pass,
rotate.
and Three types of load plots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants