Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/migration dropouts #351

Closed
wants to merge 5 commits into from
Closed

Fix/migration dropouts #351

wants to merge 5 commits into from

Conversation

DerekCrannaford
Copy link
Contributor

Description

Be sure migration table schema is conformed on any new/clean deployment

Changelog

add rich fields to the 'hard coded' (pre)installation admin migrations, so migration table always has full fields supported on new/clean installs
patch 20190117125821-AdminAddMigrationMessageTextColumns.php for if-not-exists-column etc

issues: #349

@iceaxeliehne
Copy link
Contributor

Just checking some things.
The issue this addresses, does it occur only in CDK deploy?
Can I force main module migrations to run before admin for testing ? I suspect I can do this manually or using cmfive.php?

@DerekCrannaford
Copy link
Contributor Author

Just checking some things. The issue this addresses, does it occur only in CDK deploy? Can I force main module migrations to run before admin for testing ? I suspect I can do this manually or using cmfive.php?

The errors this PR prevents, can happen anywhere, depending on order of searching modules = not meaningfully specific to any-or-other deployment method, but coincidental we don't often observe the failed migration sequence.

If you have control of your own test-env, without this PR you can:

  • allow env to build, by whatever means (local codespace CDK etc)
  • login -> check migrations -> rerun if any failed batch for eg: InboxRemove and MainRestrictable
  • use cmfive tools for DB to capture a backup of the DB with the complete migrations, and locate it where tests will look for latest filename as testDB snapshot source

Or - pending this PR - switch your dev-env over to this fix/ branch

  • use cmfive tools to make new testDB setup/snapshot = will purge then rerun migrations with the fix/ branch patch

@DerekCrannaford
Copy link
Contributor Author

Review suggested implementations changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants