Feature/display billable hours #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/display billable hours
There was a problem hiding this comment.
would it be possible to have getTotalTimeByTimeType return a map of timetypes to total minutes, as opposed to formatted hour/minute strings? this would make the maths of adding things up a lot easier in getTotalTimeByBillable, make things a bit more readable?
There was a problem hiding this comment.
can we move all the style="..."s and the <style> block into SCSS, for consistency?
| $time_totals = $this->getTotalTimeByTimeType($task_id); | ||
| $time_totals_in_seconds = []; | ||
| foreach ($time_totals as $time_total) { | ||
| $time_totals_in_seconds[] = strtotime("1970-01-01 $time_total UTC"); |
There was a problem hiding this comment.
is there any other way to do this? DateTime perhaps? https://www.php.net/manual/en/class.datetime.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Changelog
refs:
issues:
Other Information
Docs pull request: