Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with group users having the same name #218

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

tynanmatthews
Copy link
Contributor

Checklist

  • I'm using the correct PHP Version (7.4 for current, 7.2 for legacy).
  • I've added comments to any new methods I've created or where else relevant.
  • I've replaced magic method usage on DbService classes with the getInstance() static method.
  • I've written any documentation for new features or where else relevant in the docs repo.

Description

Fixed an issue where users with the same name would not be shown in the list when attempting to add new members.
This was done by changing the key from full name to user ID when fetching the list of users.
Also added email addresses to differentiate users with the same name.

Changelog

refs:
issues: #207

Other Information

Docs pull request:

@chris-bateman
Copy link
Member

@tynanmatthews could you look at this and work with @DaltJM on deploying it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants