refactor: reduce confusion between Settings and CardOption

Rename SettingsController to CardOptionsController.
2anki · Dec 24, 2024 · 2c67b4d · 2c67b4d
1 parent d7d7232
commit 2c67b4d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/...ingsController/SettingsController.test.ts → ...sController/CardOptionsController.test.ts b/...ingsController/SettingsController.test.ts → ...sController/CardOptionsController.test.ts
@@ -1,7 +1,7 @@
 import SettingsService, {
   IServiceSettings,
 } from '../../services/SettingsService';
-import SettingsController from './SettingsController';
+import CardOptionsController from './CardOptionsController';
 import { SettingsInitializer } from '../../data_layer/public/Settings';
 
 class FakeSettingsService implements IServiceSettings {
@@ -25,7 +25,7 @@ function testDefaultSettings(
   type: 'client' | 'server',
   expectedOptions: Record<string, string>
 ) {
-  const settingsController = new SettingsController(new FakeSettingsService());
+  const settingsController = new CardOptionsController(new FakeSettingsService());
   const defaultOptions = settingsController.getDefaultSettingsCardOptions(type);
   expect(defaultOptions).toStrictEqual(expectedOptions);
 }

diff --git a/.../SettingsController/SettingsController.ts → ...ptionsController/CardOptionsController.ts b/.../SettingsController/SettingsController.ts → ...ptionsController/CardOptionsController.ts
@@ -5,7 +5,7 @@ import { getOwner } from '../../lib/User/getOwner';
 import supportedOptions, { CardOption } from './supportedOptions';
 import Settings from '../../lib/parser/Settings';
 
-class SettingsController {
+class CardOptionsController {
   constructor(private readonly service: IServiceSettings) {}
 
   async createSetting(req: Request, res: Response) {
@@ -74,4 +74,4 @@ class SettingsController {
   }
 }
 
-export default SettingsController;
+export default CardOptionsController;
diff --git a/...rs/SettingsController/supportedOptions.ts → ...CardOptionsController/supportedOptions.ts b/...rs/SettingsController/supportedOptions.ts → ...CardOptionsController/supportedOptions.ts
diff --git a/src/routes/SettingsRouter.ts b/src/routes/SettingsRouter.ts
@@ -1,15 +1,15 @@
 import express from 'express';
 
 import RequireAuthentication from './middleware/RequireAuthentication';
-import SettingsController from '../controllers/SettingsController/SettingsController';
+import CardOptionsController from '../controllers/CardOptionsController/CardOptionsController';
 import SettingsRepository from '../data_layer/SettingsRepository';
 import { getDatabase } from '../data_layer';
 import SettingsService from '../services/SettingsService';
 
 const SettingsRouter = () => {
   const router = express.Router();
   const database = getDatabase();
-  const controller = new SettingsController(
+  const controller = new CardOptionsController(
     new SettingsService(new SettingsRepository(database))
   );