Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(calls): snake_case parameters and time serialization #57

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(calls): snake_case parameters and time serialization #57

merged 1 commit into from
Dec 2, 2024

Conversation

genaris
Copy link
Collaborator

@genaris genaris commented Dec 2, 2024

  • Changed call-offer parameters to use snake_case instead of camelCase, to follow DIDComm conventions as exposed in DIDComm Best practices
  • Likewise, some updates to offer_*_time transformation in order to follow this convention

@genaris genaris requested a review from lotharking December 2, 2024 19:26
@lotharking lotharking merged commit ff96e56 into main Dec 2, 2024
6 checks passed
@lotharking lotharking deleted the fix/call-offer-date-types branch December 2, 2024 19:31
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotharking lotharking lotharking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genaris @lotharking