fix: add method removeListener as deprecated

1fabiopereira · Jun 3, 2023 · 1b1877f · 1b1877f
1 parent ec4791f
commit 1b1877f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-pitch-detector",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "description": "High performance real time pitch detection.",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",

diff --git a/src/internal/pitch-detector/__tests__/pitch-detector.spec.ts b/src/internal/pitch-detector/__tests__/pitch-detector.spec.ts
@@ -67,7 +67,7 @@ describe('PitchDetector', () => {
   it.each([
     ['addListener', 'addListener'],
     ['removeAllListeners', 'removeAllListeners'],
-    ['removeSubscription', 'removeListener'],
+    ['removeAllListeners', 'removeListener'],
   ])(
     'should call %s method from event emitter when %s method will be called',
     async (target: string, method: string) => {

diff --git a/src/internal/pitch-detector/index.ts b/src/internal/pitch-detector/index.ts
@@ -133,10 +133,11 @@ export class InternalPitchDetector {
 
   /**
    * Method event listeners
+   * @deprecated since version 0.1.4, instead use `removeAllListeners`
    */
   removeListener(subscription: Subscription): void {
     if (subscription) {
-      this.event?.removeSubscription(subscription);
+      this.event?.removeAllListeners('data');
     }
   }