This repository has been archived by the owner on Jun 27, 2018. It is now read-only.
Allow late static binding of DataConnector Class constants in DataConnector_pdo #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nector_pdo Changed “DataConnector::” to “static::”
|
👍 |
Applied the same DataConnector:: to static:: fix for mysql and sqlite classes.
|
Thanks. I will update the other sub-classes as I have a couple more almost ready to be added (for PostgreSQL and MySQLi). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed “DataConnector::” to “static::” in DataConnector_pdo.php
This allows for late static binding (PHP 5.3+) of the DataConnector class constants. When subclassing the DataConnector class, the table name constants defined in the subclass are/were not respected. Using static:: allows subclasses to override the table name constants, which I believe is the desired behavior.
http://php.net/manual/en/language.oop5.late-static-bindings.php
I only updated the PDO class, because it's the one I use, but if this is on the right track then I'm happy to update the rest. Cheers!