Skip to content
This repository has been archived by the owner on Jun 27, 2018. It is now read-only.

Define consumer profile member variable for ToolConsumer #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Define consumer profile member variable for ToolConsumer #10

wants to merge 1 commit into from

Conversation

junpataleta
Copy link
Contributor

Fix for #9

@spvickers
Copy link
Contributor

Thanks for the request, but I am not sure I follow the reasoning behind it. A Tool Profile is associated with a Tool Provider, so why should this be added as a property of the ToolConsmer object? How would you intend to use this? Do we need to extend the data model to store it? Thanks.

@spvickers spvickers closed this Oct 13, 2016
@spvickers spvickers reopened this Oct 13, 2016
@junpataleta
Copy link
Contributor Author

junpataleta commented Oct 14, 2016

Hi Stephen,

The $profile variable is being set in the ToolConsumer::initialize() method, but it is not actually declared in the ToolConsumer class.

Furthermore, there are various instances in the library where it is being accessed (e.g. in DataConnector_mysql.php).

So I assume that this needs to be declared as a public variable.

@junpataleta
Copy link
Contributor Author

Sorry, I totally misunderstood the profile variable as a ToolProfile object and realised that it refers to the tool consumer profile data. Which is basically a generic object type. I have updated the patch with the correct definition in the PHPDoc.

@junpataleta junpataleta changed the title Define ToolProfile member variable for ToolConsumer Define consumer profile member variable for ToolConsumer Oct 18, 2016
@jeremeamia
Copy link

Yeah, this looks fine. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants