Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI config syntax fixes #4079

Merged
merged 1 commit into from
Aug 21, 2024
Merged

CircleCI config syntax fixes #4079

merged 1 commit into from
Aug 21, 2024

Conversation

caleywoods
Copy link
Contributor

@caleywoods caleywoods commented Aug 21, 2024

Pull request summary

I noticed in the CircleCI dashboard that the .circleci/config.yml file on main had syntax issues. I looked at the config file locally and the CircleCI config validator that is part of their CLI toolkit reported the same issues.

I used the CircleCI config editor on their site to help understand what needed to change since both the CLI validator and the error in the CircleCI dashboard are hard to understand. The changes are simple, just moving the lint, build, and verify steps into run blocks, their previous syntax looked like maybe it was meant to use commands lint, build, and verify but they weren't being defined in a commands block prior to being used.

@caleywoods caleywoods requested a review from a team as a code owner August 21, 2024 18:09
Copy link
Member

@cantsin cantsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caleywoods
Copy link
Contributor Author

@cantsin CircleCI config file fixes

@caleywoods caleywoods merged commit 90415c9 into main Aug 21, 2024
9 checks passed
@caleywoods caleywoods deleted the caley/fix-circleci-config branch August 21, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants