Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add library publishing and update Gradle/Kotlin versions #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cypherdare
Copy link

This will allow SVG non-stop to be used as a project dependency via JitPack as explained in the updated README. It will take effect after tagging the pulled commit with "1.1.2" and then opening this Jitpack link to give JitPack a chance to build and publish it.

I tested Gradle assemble and the built application to confirm none of the Gradle changes affect current use of the app.

I updated the Gradle and Kotlin versions to help future-proof it.

@cypherdare
Copy link
Author

*will take effect after creating a release named "1.1.2" before opening that Jitpack link.

By the way, I created this PR after I realized the project could easily be both an application and library based on how you already structured your code. No need for me to maintain a fork to be able to use it in a Gradle plugin.

@cypherdare
Copy link
Author

cypherdare commented Mar 13, 2022

The two follow-up commits:

  • I realized this couldn't be used from Java without a package declared, in case anyone wants to use it in a Java project.
  • I discovered you're supposed to use io.github rather than com.github as your prefix. details here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant