Recognize .ico files with a search query
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eleventy-api-indieweb-avatar ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I’m on board with this change but it needs to use the URL API: https://developer.mozilla.org/en-US/docs/Web/API/URL_API Been bit too many times on string splitting URLs! (Also sorry I’m so late on this but it looks like the test case no longer falls prey to this issue) |
|
Should we just skip the test, and instead, refactor the code which checks the URL file extension? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore a URL's search query and/or hash segment when checking the favicon's extension.