Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Sync page logic into a provider pattern #3630

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Sep 5, 2023

Description of the Change

In #3159 we abstracted the business logic of Instant Results searching into a provder pattern to decouple it from a specific UI. This PR does the same for the sync page.

Closes #3629

How to test the Change

  • No user facing changes, the Sync page should continue to function as expected.

Changelog Entry

  • Changed - Abstracted Sync page logic into a provider pattern.

Credits

Props @JakePT

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@JakePT JakePT added this to the 5.0.0 milestone Sep 5, 2023
@felipeelia felipeelia changed the base branch from develop to 5.0.0 September 5, 2023 17:40
@felipeelia felipeelia merged commit 49033b7 into 5.0.0 Sep 12, 2023
9 checks passed
@felipeelia felipeelia deleted the feature/3629 branch September 12, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract Sync page logic into a provider pattern
2 participants