Let onMessage handlers coexist #250
Open
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17Amir17
reviewed
Dec 29, 2024
| export const RichText = ({ | ||
| editor, | ||
| onMessage, | ||
| exclusivelyUseCustomOnMessage = true, |
There was a problem hiding this comment.
What is the use-case for this?
There was a problem hiding this comment.
for the prop? Keeping compatibility and maintaining current behaviour so I don't accidentally break peoples' setups. And in general the use-case for the pr is being able to use the onMessage prop of the webview without messing up tentap's own behaviour
There was a problem hiding this comment.
Any case it's a very important feature for me, so I know there's a usecase haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour we have here is that if you pass your own onMessage handler, it will override the existing TenTap one, which is, I think, not the intended behaviour in most cases.
Therefore I just introduced another prop that makes this possible, while maintaining the original behaviour. Basically, if you use onMessage right now through tentap, and you upgrade to this version, nothing changes.