[FEATURE] Matomo - Envoyer les events liés à l'utilisation du Expand (toggle) (PIX-15774) #10889
+154
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
dianeCdrPix
force-pushed
the
pix-15774-add-matomo-event-for-expand
branch
2 times, most recently
from
9a2ba7a to
4c6e4c6
Compare
er-lim
changed the title
er-lim
changed the title
er-lim
force-pushed
the
pix-15774-add-matomo-event-for-expand
branch
2 times, most recently
from
f2b731a to
10a0407
Compare
er-lim
changed the title
Co-authored-by: Eric Lim <[email protected]>
Co-authored-by: Diane Cordier <[email protected]>
clemlatz
force-pushed
the
pix-15774-add-matomo-event-for-expand
branch
from
10a0407 to
cc57b25
Compare
clemlatz
approved these changes
Jan 2, 2025
| export default class ModulixExpand extends Component { | ||
| @action | ||
| onExpandToggle(event) { | ||
| const isOpen = event?.srcElement?.open; |
There was a problem hiding this comment.
question: est-ce qu'il y a un cas où event ou srcElement peuvent être undefined ?
Si oui, l'évènement envoyé à Matomo sera une fermeture, est-ce vraiment ce qu'on veut ?
suggestion: si isOpen peut être vraiment undefined, cela signifie qu'on on peut ne pas avoir l'information, donc il faudrait gérer dans un troisième cas qui ne soit ni "Ouverture" ni "Fermeture" mais "Clic".
Comment on lines
+30
to
+31
| module('when click on Expand', function () { | ||
| test('should call method onExpandToggle', async function (assert) { |
There was a problem hiding this comment.
suggestion : de formulation orientée utilisateur + il faudrait tester aussi que quand on clique deux fois, ça appelle la méthode avec isOpen: false
Suggested change
| module('when click on Expand', function () { | |
| test('should call method onExpandToggle', async function (assert) { | |
| module('when users opens Expand element', function () { | |
| test('should call method onExpandToggle with isOpen set to true', async function (assert) { |
Comment on lines
+1174
to
+1175
| module('when user clicks on expand element', function () { | ||
| test('should push metrics event', async function (assert) { |
There was a problem hiding this comment.
suggestion : il faudrait tester aussi le cas où ça appelle la méthode avec "Fermeture"
Suggested change
| module('when user clicks on expand element', function () { | |
| test('should push metrics event', async function (assert) { | |
| module('when user clicks expand element', function () { | |
| module('when isOpen argument is true', function () { | |
| test('should push metrics event with "Ouverture" event name', async function (assert) { | |
| //… | |
| }); | |
| module('when isOpen argument is false', function () { | |
| test('should push metrics event with "Fermeture" event name', async function (assert) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎁 Proposition
Ajouter une fonction dans Passage pour appeler le service metrics et envoyer des informations à Matomo sur le click d'un Expand
🧦 Remarques
togglecomme mis dans la doc de la balise detailssummarysinon le contenu ne s'affiche pas.🎅 Pour tester (en local)