Update test.yml #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait-for-it.sh should work now
|
@ssk090 Yep, it's working. I think we don't need to add a timeout also in the workflow file because a 15-second timeout is already added in integration.sh |
omkardongre
reviewed
Jun 14, 2024
| run: chmod +x ./scripts/wait-for-it.sh | ||
|
|
||
| - name: Wait for Database | ||
| run: ./scripts/wait-for-it.sh db:5432 --timeout=30 --strict -- echo "Database is up" |
There was a problem hiding this comment.
This is already checked in the script scripts/run-integration.sh
Why to add here again?
Better just update the run-integration.sh and run this script ./scripts/wait-for-it.sh with bash, as it seem by default github action running the script in sh shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait-for-it.sh should work now