Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed europe region and converted jitter values from s to ms #3417

Merged
merged 16 commits into from
Dec 12, 2024
Merged

fix: Removed europe region and converted jitter values from s to ms #3417

merged 16 commits into from
Dec 12, 2024

Conversation

monkCommits
Copy link
Contributor

@monkCommits monkCommits commented Dec 11, 2024 •
edited
Loading

Description

Removed the region Europe as it is not needed as of now.
Converted jitter values from s to ms.

List which issues are fixed by this PR. You must list at least one issue.

  • Europe listed in the Regions.
  • Jitter values appearing in s

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Merging:

  • Squash merge to dev
  • Merge commit to publish-alpha and main

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:58pm
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:58pm

github-actions[bot]
github-actions bot reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution.

If you are fixing a bug, please reference the issue number in the description.

If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.

We really appreciate your contribution!

@monkCommits monkCommits changed the base branch from main to dev December 11, 2024 11:39
@KaustubhKumar05 KaustubhKumar05 enabled auto-merge (squash) December 11, 2024 11:54
@ygit ygit changed the title Fix: Removed europe region and converted jitter values from s to ms fix: Removed europe region and converted jitter values from s to ms Dec 11, 2024
@ygit ygit requested a review from KaustubhKumar05 December 11, 2024 12:18
ygit
ygit previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit requested a review from hdz-666 December 11, 2024 12:20
@KaustubhKumar05 KaustubhKumar05 marked this pull request as draft December 12, 2024 05:50
auto-merge was automatically disabled December 12, 2024 05:50

Pull request was converted to draft

@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review December 12, 2024 05:51
@KaustubhKumar05 KaustubhKumar05 requested a review from ygit December 12, 2024 05:51
@ygit ygit enabled auto-merge (squash) December 12, 2024 05:52
ygit
ygit approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit merged commit ee1f70c into dev Dec 12, 2024
4 checks passed
@ygit ygit deleted the fix/ISS-30835-remove-europe-region branch December 12, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@KaustubhKumar05 KaustubhKumar05 KaustubhKumar05 approved these changes

@ygit ygit ygit approved these changes

@hdz-666 hdz-666 Awaiting requested review from hdz-666

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monkCommits @ygit @KaustubhKumar05 @raviteja83