Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doximity rtc peer connection keyword modified to public from readonly #3415

Conversation

hdz-666
Copy link
Collaborator

@hdz-666 hdz-666 commented Dec 11, 2024

Description

image

Implementation note, gotchas, related work and Future TODOs (optional)

Exposed nativeConnection class for getting rtc peer connection

__hms.sdk.transport.subscribeConnection
__hms.sdk.transport.publishConnection

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Merging:

  • Squash merge to dev
  • Merge commit to publish-alpha and main

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 6:35am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 6:35am

@hdz-666 hdz-666 changed the title Feat/iss 30832 doximity rtc peer connection public expose to class doximity rtc peer connection public expose to class Dec 11, 2024
@hdz-666 hdz-666 changed the title doximity rtc peer connection public expose to class doximity rtc peer connection keyword modified to public from readonly Dec 11, 2024
@hdz-666 hdz-666 changed the base branch from main to dev December 11, 2024 06:32
@KaustubhKumar05
Copy link
Collaborator

KaustubhKumar05 commented Dec 11, 2024

@raviteja83 are these changes sufficient? I don't have full context on how they plan to use it

@ygit ygit marked this pull request as draft December 11, 2024 07:58
@ygit ygit requested review from ygit and KaustubhKumar05 December 11, 2024 07:59
* @abstract
* @type {RTCPeerConnection}
*/
abstract nativeConnection: RTCPeerConnection;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be readonly so that it shouldn't be allowed to be modified. They just need a read access which we don't expose directly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 private getNativePublishPeerConnection() {
    return this.transport.getPublishConnection()?.nativeConnection;
  }

Just adding two methods - one for publish and other for subscribe in sdk/index and HMSSDKActions should be enough. we can even combine this to getNativePeerConnections and return and object with publish and subscribe

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add validations whether join has happened or not and throwing an error suggesting to call post joiin.

@raviteja83 raviteja83 closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants