-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doximity rtc peer connection keyword modified to public from readonly #3415
doximity rtc peer connection keyword modified to public from readonly #3415
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@raviteja83 are these changes sufficient? I don't have full context on how they plan to use it |
…lic-expose-to-class
* @abstract | ||
* @type {RTCPeerConnection} | ||
*/ | ||
abstract nativeConnection: RTCPeerConnection; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be readonly so that it shouldn't be allowed to be modified. They just need a read access which we don't expose directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private getNativePublishPeerConnection() {
return this.transport.getPublishConnection()?.nativeConnection;
}
Just adding two methods - one for publish and other for subscribe in sdk/index and HMSSDKActions should be enough. we can even combine this to getNativePeerConnections and return and object with publish and subscribe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add validations whether join has happened or not and throwing an error suggesting to call post joiin.
Description
Implementation note, gotchas, related work and Future TODOs (optional)
Exposed nativeConnection class for getting rtc peer connection
__hms.sdk.transport.subscribeConnection
__hms.sdk.transport.publishConnection
Pre-launch Checklist
Merging: