Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persisting audio & video device selection across local peer's role change #3377

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Persisting audio & video device selection across local peer's role change #3377

merged 3 commits into from
Nov 21, 2024

Conversation

ygit
Copy link
Member

@ygit ygit commented Nov 19, 2024

Description

  • Using previous selection for device inputs after local role change

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Merging:

  • Squash merge to dev
  • Merge commit to publish-alpha and main

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:27am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:27am

@ygit ygit enabled auto-merge (squash) November 19, 2024 14:42
@ygit ygit merged commit 939327b into dev Nov 21, 2024
4 checks passed
@ygit ygit deleted the fix/ISS-30656-persist-video-device-id branch November 21, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaustubhKumar05 KaustubhKumar05 KaustubhKumar05 left review comments

@hdz-666 hdz-666 hdz-666 approved these changes

@raviteja83 raviteja83 raviteja83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ygit @raviteja83 @KaustubhKumar05 @hdz-666