Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render stats for nerds when opened #3364

Merged
merged 9 commits into from
Nov 11, 2024
Merged

fix: render stats for nerds when opened #3364

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0d9448b
fix: getdebuginfo fails in skip preview flow
KaustubhKumar05 Nov 8, 2024
c9f09ae
fix: copy spacing
KaustubhKumar05 Nov 8, 2024
8327b88
fix: conditionally render stats for nerds modal
KaustubhKumar05 Nov 8, 2024
f3b3118
fix: mark method as internal
KaustubhKumar05 Nov 8, 2024
65dbd2b
fix: convert warning to debug
KaustubhKumar05 Nov 8, 2024
9a158db
fix: throw error if method is called before join
KaustubhKumar05 Nov 11, 2024
bad3cd8
fix: convert debug log to error log
KaustubhKumar05 Nov 11, 2024
59d0339
fix: render stats for nerds when opened
KaustubhKumar05 Nov 11, 2024
f1143ac
Merge branch 'dev' into fix/WEB-3075-stats-for-nerds-mweb
KaustubhKumar05 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/roomkit-react/src/Prebuilt/components/MoreSettings/SplitComponents/MwebOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ export const MwebOptions = ({
</Sheet.Root>
<SettingsModal open={openSettingsSheet} onOpenChange={setOpenSettingsSheet} screenType={screenType} />

<StatsForNerds open={openStatsForNerdsSheet} onOpenChange={setOpenStatsForNerdsSheet} />
{openSettingsSheet && <StatsForNerds open={openStatsForNerdsSheet} onOpenChange={setOpenStatsForNerdsSheet} />}

{openModals.has(MODALS.MUTE_ALL) && (
<MuteAllModal onOpenChange={(value: boolean) => updateState(MODALS.MUTE_ALL, value)} isMobile />
Expand Down