Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: local peer Inset tile incorrect aspect ratio on mweb #3362

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: local peer Inset tile incorrect aspect ratio on mweb #3362

merged 1 commit into from
Nov 11, 2024

Conversation

ygit
Copy link
Member

@ygit ygit commented Nov 11, 2024

Details(context, link the issue, how was the bug fixed, what does the new feature do)

  • Local peer inset tile has incorrect aspect ratio on mweb for QA links
  • This issue is due to stitches upgrade which requires that aspectRatio should be passed as a string

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 7:01am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 7:01am

@hdz-666 hdz-666 merged commit bdca62e into dev Nov 11, 2024
4 checks passed
@hdz-666 hdz-666 deleted the fix/WEB-3081-fix-inset-tile-aspect-ratio branch November 11, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdz-666 hdz-666 hdz-666 approved these changes

@KaustubhKumar05 KaustubhKumar05 KaustubhKumar05 approved these changes

@raviteja83 raviteja83 Awaiting requested review from raviteja83

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ygit @KaustubhKumar05 @hdz-666