Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: animate resize to prevent flickers #3303

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Oct 4, 2024

Steps to repro:

  • Open chat/participant list when multiple tiles are present
  • The issue is more noticeable when downsizing the screen

Bundle size increase:

Prod gzip:


image


Deployment gzip:


image

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 10:09am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 10:09am

@raviteja83 raviteja83 marked this pull request as draft October 5, 2024 01:30
@ygit
Copy link
Member

ygit commented Nov 14, 2024

@KaustubhKumar05 can you resolve the conflicts on this PR?

Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaustubhKumar05 KaustubhKumar05 merged commit 8e5a734 into dev Nov 15, 2024
4 checks passed
@KaustubhKumar05 KaustubhKumar05 deleted the fix/WEB-2264-layout-resize-animation branch November 15, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants