fix: correct message for first peer #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amar-1995
requested review from
raviteja83,
eswarclynn and
KaustubhKumar05
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KaustubhKumar05
approved these changes
May 22, 2024
|
If multiple non hosts join, they will still see the "You're the first to join" message @amar-1995? |
KaustubhKumar05
pushed a commit
that referenced
this pull request
May 22, 2024
Co-authored-by: Amar Bathwal <[email protected]>
KaustubhKumar05
added a commit
that referenced
this pull request
May 23, 2024
* fix: correct message for first peer (#2923) * fix: alignment of textarea and send icon in overlay chat --------- Co-authored-by: Amar Bathwal <[email protected]> Co-authored-by: Kaustubh Kumar <[email protected]>
KaustubhKumar05
pushed a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details(context, link the issue, how was the bug fixed, what does the new feature do)
Implementation note, gotchas, related work and Future TODOs (optional)