Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extra get poll responses calls #2897

Merged
merged 17 commits into from
May 21, 2024
Merged

fix: extra get poll responses calls #2897

merged 17 commits into from
May 21, 2024

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented May 14, 2024 •
edited
Loading

  • Fix extra get poll responses calls
  • Update the state when local peer opens the voting view
  • Store responses in app data
  • Fix store not being updated
  • Regression testing
    • Fix switching between polls/quizzes

@vercel Vercel
Copy link

vercel bot commented May 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 11:16am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 11:16am

@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review May 15, 2024 08:34
@KaustubhKumar05 KaustubhKumar05 force-pushed the fix-get-poll-responses branch from 0e313f1 to 8b77a72 Compare May 15, 2024 08:56
@KaustubhKumar05 KaustubhKumar05 marked this pull request as draft May 15, 2024 10:04
@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review May 21, 2024 08:52
@KaustubhKumar05 KaustubhKumar05 marked this pull request as draft May 21, 2024 10:09
@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review May 21, 2024 11:13
@raviteja83 raviteja83 merged commit 2485cd4 into dev May 21, 2024
4 checks passed
@raviteja83 raviteja83 deleted the fix-get-poll-responses branch May 21, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviteja83 raviteja83 raviteja83 approved these changes

@eswarclynn eswarclynn Awaiting requested review from eswarclynn

@amar-1995 amar-1995 Awaiting requested review from amar-1995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaustubhKumar05 @raviteja83