Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update pluginUsageTracker implementation #2713

Merged
merged 24 commits into from
Mar 21, 2024
Merged

fix: update pluginUsageTracker implementation #2713

merged 24 commits into from
Mar 21, 2024

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Mar 18, 2024 •
edited
Loading

  • Combine usage across device change, plugin addition/removal
  • Should be session/room specific to accommodate multiple rooms
  • Toggle methods inside HMSKrispPlugin
  • Send the value via krisp.usage event before leave

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 6:32pm
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 6:32pm

@KaustubhKumar05 KaustubhKumar05 marked this pull request as draft March 18, 2024 06:34
@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review March 18, 2024 08:32
@KaustubhKumar05 KaustubhKumar05 changed the title feat: accept sessionID when initing plugins fix: update pluginUsageTracker implementation Mar 19, 2024
@KaustubhKumar05 KaustubhKumar05 marked this pull request as draft March 19, 2024 06:46
@raviteja83 raviteja83 merged commit f802c94 into dev Mar 21, 2024
4 of 5 checks passed
@raviteja83 raviteja83 deleted the WEB-2670-session-id branch March 21, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviteja83 raviteja83 raviteja83 approved these changes

@eswarclynn eswarclynn Awaiting requested review from eswarclynn

@amar-1995 amar-1995 Awaiting requested review from amar-1995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaustubhKumar05 @raviteja83