Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hls layout for mweb #2637

Merged
merged 19 commits into from
Mar 4, 2024
Merged

fix: hls layout for mweb #2637

merged 19 commits into from
Mar 4, 2024

Conversation

raviteja83
Copy link
Collaborator

Details(context, link the issue, how was the bug fixed, what does the new feature do)

Implementation note, gotchas, related work and Future TODOs (optional)

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:56am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:56am

Copy link
Contributor

@amar-1995 amar-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross icon not visible
Uploading Screenshot 2024-03-01 at 6.08.02 PM.png…

amar-1995
amar-1995 previously approved these changes Mar 4, 2024
Copy link
Contributor

@amar-1995 amar-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stream is not ending, we are not getting stream ended

@amar-1995 amar-1995 self-requested a review March 4, 2024 04:00
Copy link
Contributor

@amar-1995 amar-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raviteja83 raviteja83 merged commit bda96ed into main Mar 4, 2024
5 checks passed
@raviteja83 raviteja83 deleted the fix/WEB-2702 branch March 4, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants