Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use title in streaming from layout api #2616

Merged
merged 9 commits into from
Feb 29, 2024
Merged

feat: use title in streaming from layout api #2616

merged 9 commits into from
Feb 29, 2024

Conversation

amar-1995
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 11:34am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 11:34am

@amar-1995 amar-1995 requested a review from raviteja83 February 28, 2024 16:19
@amar-1995 amar-1995 requested a review from raviteja83 February 28, 2024 16:21
@KaustubhKumar05
Copy link
Collaborator

KaustubhKumar05 commented Feb 28, 2024 •
edited
Loading

image

  • The bottom sheet content is not aligned
  • The title and description are not being rendered anywhere in desktop or mobile for HLS viewer, intentional?

@KaustubhKumar05
Copy link
Collaborator

KaustubhKumar05 commented Feb 28, 2024 •
edited
Loading

image

This is desktop, height for the input has decreased, is this by design?

@raviteja83 raviteja83 changed the title feat: remove title hardcoded feat: use title in streaming from layout api Feb 28, 2024
@amar-1995 amar-1995 requested a review from raviteja83 February 29, 2024 09:27
@KaustubhKumar05
Copy link
Collaborator

KaustubhKumar05 commented Feb 29, 2024 •
edited
Loading

On mweb the emojis are open by default before the stream starts


image

The sheet content does not take full width


image


There is a gap above the first chat


image

@raviteja83
Copy link
Collaborator

I have fixed the chat footer in a different PR.

@raviteja83 raviteja83 merged commit d2f26c7 into main Feb 29, 2024
5 checks passed
@raviteja83 raviteja83 deleted the WEB-2679-title-hardcoded branch February 29, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaustubhKumar05 KaustubhKumar05 KaustubhKumar05 approved these changes

@raviteja83 raviteja83 raviteja83 approved these changes

@eswarclynn eswarclynn Awaiting requested review from eswarclynn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amar-1995 @KaustubhKumar05 @raviteja83