fix: whiteboard zoom on mweb #2424
Closed
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A JIRA Issue ID is missing from your branch name! 🦄 Your branch: fix/whiteboard-mweb If this is your first time contributing to this repository - welcome! Please refer to jira-lint to get started. Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail. Valid sample branch names:‣ feature/shiny-new-feature--mojo-10' |
raviteja83
reviewed
Jan 16, 2024
| import { Box } from '../../Layout'; | ||
| // @ts-ignore: No implicit Any | ||
| import { useSetAppDataByKey } from '../components/AppData/useUISettings'; | ||
| import { APP_DATA } from '../common/constants'; | ||
|
|
||
| const EmbedComponent = () => { | ||
| const { iframeRef } = useWhiteboard(); | ||
| const isMobile = useMedia(cssConfig.media.md); |
There was a problem hiding this comment.
we can use this inside the useWhiteboard itself.
There was a problem hiding this comment.
useWhiteboard is in react-sdk and it doesn't have access to config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details(context, Jira ticket, how was the bug fixed, what does the new feature do)
Choose one of these(put a 'x' in the bracket):
Implementation note, gotchas, related work and Future TODOs (optional)