Skip to content

Commit

Permalink
fix: clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
KaustubhKumar05 committed Aug 1, 2024
1 parent 8dfa1a8 commit f0cddeb
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 21 deletions.
9 changes: 0 additions & 9 deletions packages/hms-video-store/src/interfaces/room.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,8 @@ export interface HMSRoom {
description?: string;
max_size?: number;
large_room_optimization?: boolean;
/**
* @alpha
*/
isEffectsEnabled?: boolean;
/**
* @alpha
*/
isVBEnabled?: boolean;
/**
* @alpha
*/
effectsKey?: string;
isHipaaEnabled?: boolean;
isNoiseCancellationEnabled?: boolean;
Expand Down
9 changes: 0 additions & 9 deletions packages/hms-video-store/src/sdk/models/HMSRoom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,8 @@ export default class Room implements HMSRoom {
max_size?: number;
large_room_optimization?: boolean;
transcriptions?: HMSTranscriptionInfo[] = [];
/**
* @alpha
*/
isEffectsEnabled?: boolean;
/**
* @alpha
*/
isVBEnabled?: boolean;
/**
* @alpha
*/
effectsKey?: string;
isHipaaEnabled?: boolean;
isNoiseCancellationEnabled?: boolean;
Expand Down
4 changes: 2 additions & 2 deletions packages/hms-virtual-background/src/HMSVBPlugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ export class HMSVBPlugin implements HMSVideoPlugin {
}

isBlurSupported(): boolean {
// Not supported in Safari
return !(navigator.userAgent.includes('Safari') && !navigator.userAgent.includes('Chrome'));
const gl = this.outputCanvas?.getContext('webgl');
return !!gl?.getSupportedExtensions()?.includes('WEBGL_2D_storage');
}

checkSupport(): HMSPluginSupportResult {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ export const VBPicker = ({ backgroundMedia = [] }: { backgroundMedia: VirtualBac
if (!role) {
return;
}
hmsActions.addPluginToVideoTrack(vbObject as HMSVBPlugin, Math.floor(role.publishParams.video.frameRate / 2));
}
}
const handleDefaultBackground = async () => {
Expand Down Expand Up @@ -170,7 +171,6 @@ export const VBPicker = ({ backgroundMedia = [] }: { backgroundMedia: VirtualBac
/>

{/* Slider */}

<Flex direction="column" css={{ w: '100%', gap: '$8', mt: '$8' }}>
{background === HMSVirtualBackgroundTypes.BLUR && isEffectsEnabled && effectsKey ? (
<Box>
Expand Down

0 comments on commit f0cddeb

Please sign in to comment.