Skip to content

Commit

Permalink
fix: pdf share inside iframe
Browse files Browse the repository at this point in the history
  • Loading branch information
amar-1995 authored Dec 28, 2023
1 parent 1dc0228 commit eecb150
Show file tree
Hide file tree
Showing 13 changed files with 31 additions and 30 deletions.
4 changes: 2 additions & 2 deletions apps/100ms-custom-app/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions apps/100ms-web/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/hls-player/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/hls-stats/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/hms-noise-suppression/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/hms-video-store/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/hms-video-web/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/hms-virtual-background/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/react-icons/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/react-sdk/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions packages/react-sdk/src/hooks/usePDFShare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,11 @@ export const usePDFShare = (resetConfig?: () => void): usePDFShareResult => {
};
inProgress.current = true;
setSharing(true);
const isInsideIframe = window.self !== window.top;
await toggleScreenShare?.({
forceCurrentTab: isChromiumBased,
forceCurrentTab: isChromiumBased && !isInsideIframe,
cropElement: iframeRef.current,
preferCurrentTab: isChromiumBased,
preferCurrentTab: isChromiumBased && !isInsideIframe,
});
},
[amIScreenSharing, sendDataToPDFIframe, toggleScreenShare],
Expand Down
10 changes: 5 additions & 5 deletions packages/roomkit-react/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/roomkit-web/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit eecb150

Please sign in to comment.