fix: use math.pow for max_safe_integer

100mslive · Feb 27, 2024 · e065090 · e065090
1 parent 02b4dd1
commit e065090
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/hms-video-store/src/analytics/stats/SubscribeStatsAnalytics.ts b/packages/hms-video-store/src/analytics/stats/SubscribeStatsAnalytics.ts
@@ -14,7 +14,7 @@ import {
 } from './interfaces';
 import { HMSTrackStats } from '../../interfaces';
 import { HMSWebrtcStats } from '../../rtc-stats';
-import { JAVA_INTEGER_MAX_VALUE, SUBSCRIBE_STATS_SAMPLE_WINDOW } from '../../utils/constants';
+import { MAX_SAFE_INTEGER, SUBSCRIBE_STATS_SAMPLE_WINDOW } from '../../utils/constants';
 import AnalyticsEventFactory from '../AnalyticsEventFactory';
 
 export class SubscribeStatsAnalytics extends BaseStatsAnalytics {
@@ -93,11 +93,11 @@ export class SubscribeStatsAnalytics extends BaseStatsAnalytics {
     const videoTrack = peer?.videoTrack;
     const areBothTracksEnabled = audioTrack && videoTrack && audioTrack.enabled && videoTrack.enabled;
     if (!areBothTracksEnabled) {
-      return JAVA_INTEGER_MAX_VALUE;
+      return MAX_SAFE_INTEGER;
     }
     const audioStats = hmsStats.getRemoteTrackStats(audioTrack.trackId);
     if (!audioStats) {
-      return JAVA_INTEGER_MAX_VALUE;
+      return MAX_SAFE_INTEGER;
     }
     return audioStats.timestamp - trackStats.timestamp;
   }
@@ -179,10 +179,10 @@ class RunningRemoteTrackAnalytics extends RunningTrackAnalytics {
   private calculateAvgAvSyncForSample() {
     const avSyncValues = this.tempStats.map(stat => stat.avSync);
     const validAvSyncValues: number[] = avSyncValues.filter(
-      (value): value is number => value !== undefined && value !== JAVA_INTEGER_MAX_VALUE,
+      (value): value is number => value !== undefined && value !== MAX_SAFE_INTEGER,
     );
     if (validAvSyncValues.length === 0) {
-      return JAVA_INTEGER_MAX_VALUE;
+      return MAX_SAFE_INTEGER;
     }
     return validAvSyncValues.reduce((a, b) => a + b, 0) / validAvSyncValues.length;
   }

diff --git a/packages/hms-video-store/src/utils/constants.ts b/packages/hms-video-store/src/utils/constants.ts
@@ -34,7 +34,7 @@ export const PUBLISH_STATS_PUSH_INTERVAL = 300;
 export const SUBSCRIBE_STATS_SAMPLE_WINDOW = 10;
 export const SUBSCRIBE_STATS_PUSH_INTERVAL = 60;
 
-export const JAVA_INTEGER_MAX_VALUE = 2147483647;
+export const MAX_SAFE_INTEGER = Math.pow(2, 31) - 1;
 
 export const HMSEvents = {
   DEVICE_CHANGE: 'device-change',