refactor: update type

100mslive · Mar 26, 2024 · af75aec · af75aec
1 parent a7d1d61
commit af75aec
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 4 deletions.
diff --git a/packages/hms-video-store/src/interfaces/peer/hms-peer.ts b/packages/hms-video-store/src/interfaces/peer/hms-peer.ts
@@ -1,6 +1,8 @@
 import { HMSAudioTrack, HMSTrack, HMSVideoTrack } from '../../media/tracks';
 import { HMSRole } from '../role';
 
+export type HMSPeerType = 'sip' | 'regular';
+
 export interface HMSPeer {
   peerId: string;
   name: string;
@@ -16,7 +18,7 @@ export interface HMSPeer {
   groups?: string[];
   realtime?: boolean;
   isHandRaised: boolean;
-  type: 'sip' | 'regular';
+  type: HMSPeerType;
 
   updateRole(newRole: HMSRole): void;
   updateName(newName: string): void;

diff --git a/packages/hms-video-store/src/notification-manager/HMSNotifications.ts b/packages/hms-video-store/src/notification-manager/HMSNotifications.ts
@@ -1,4 +1,5 @@
 import { VideoTrackLayerUpdate } from '../connection/channel-messages';
+import { HMSPeerType } from '../interfaces/peer/hms-peer';
 import { HMSRole } from '../interfaces/role';
 import { HMSLocalTrack } from '../media/tracks';
 import { HMSTrack, HMSTrackSource } from '../media/tracks/HMSTrack';
@@ -39,7 +40,7 @@ export interface Info {
   name: string;
   data: string;
   user_id: string;
-  type: 'sip' | 'regular';
+  type: HMSPeerType;
 }
 
 export enum HMSRecordingState {

diff --git a/packages/hms-video-store/src/reactive-store/adapter.ts b/packages/hms-video-store/src/reactive-store/adapter.ts
@@ -51,6 +51,7 @@ export class SDKToHMS {
       joinedAt: sdkPeer.joinedAt,
       groups: sdkPeer.groups,
       isHandRaised: sdkPeer.isHandRaised,
+      type: sdkPeer.type,
     };
   }
 

diff --git a/packages/hms-video-store/src/schema/peer.ts b/packages/hms-video-store/src/schema/peer.ts
@@ -5,6 +5,7 @@ import {
   HMSSimulcastLayerDefinition,
   ScreenCaptureHandle,
 } from '../interfaces';
+import { HMSPeerType } from '../interfaces/peer/hms-peer';
 
 export type HMSPeerID = string;
 export type HMSTrackID = string;
@@ -42,6 +43,7 @@ export interface HMSPeer {
   joinedAt?: Date;
   groups?: HMSGroupName[];
   isHandRaised: boolean;
+  type: HMSPeerType;
 }
 
 /**

diff --git a/packages/hms-video-store/src/sdk/models/peer/HMSPeer.ts b/packages/hms-video-store/src/sdk/models/peer/HMSPeer.ts
@@ -1,4 +1,5 @@
 import { HMSPeer as IHMSPeer } from '../../../interfaces/peer';
+import { HMSPeerType } from '../../../interfaces/peer/hms-peer';
 import { HMSRole } from '../../../interfaces/role';
 import { HMSAudioTrack, HMSTrack, HMSVideoTrack } from '../../../media/tracks';
 import { HAND_RAISE_GROUP_NAME } from '../../../utils/constants';
@@ -16,7 +17,7 @@ export type HMSPeerInit = {
   groups?: string[];
   realtime?: boolean;
   isHandRaised?: boolean;
-  type: 'sip' | 'regular';
+  type: HMSPeerType;
 };
 
 export class HMSPeer implements IHMSPeer {
@@ -33,7 +34,7 @@ export class HMSPeer implements IHMSPeer {
   networkQuality?: number;
   groups?: string[];
   realtime?: boolean;
-  type: 'sip' | 'regular';
+  type: HMSPeerType;
 
   constructor({
     peerId,

diff --git a/packages/hms-video-store/src/test/fakeStore/fakeHMSStore.ts b/packages/hms-video-store/src/test/fakeStore/fakeHMSStore.ts
@@ -98,6 +98,7 @@ export const makeFakeStore = (): HMSStore => {
         metadata: '{}',
         groups: [],
         isHandRaised: false,
+        type: 'regular',
       },
       '2': {
         id: '2',
@@ -110,6 +111,7 @@ export const makeFakeStore = (): HMSStore => {
         metadata: '{"hello":"world"}',
         groups: [],
         isHandRaised: false,
+        type: 'regular',
       },
       '3': {
         id: '3',
@@ -121,6 +123,7 @@ export const makeFakeStore = (): HMSStore => {
         auxiliaryTracks: [],
         groups: [],
         isHandRaised: false,
+        type: 'regular',
       },
     },
     tracks: {

diff --git a/packages/hms-video-store/src/test/fixtures.ts b/packages/hms-video-store/src/test/fixtures.ts
@@ -20,5 +20,6 @@ export const makeFakePeer = (): HMSPeer => {
     videoTrack: '',
     groups: [],
     isHandRaised: false,
+    type: 'regular',
   };
 };