Skip to content

Commit

Permalink
fix: clean up loaderboard code
Browse files Browse the repository at this point in the history
  • Loading branch information
KaustubhKumar05 committed May 20, 2024
1 parent da1a7c8 commit 9eff6c8
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion packages/hms-video-store/src/interfaces/update-listener.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export enum HMSPollsUpdate {
POLL_STOPPED,
POLLS_LIST,
POLL_STATS_UPDATED,
// POLL_LEADERBOARD_SHARED,
}

export interface HMSAudioListener {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,4 @@ export const POLL_NOTIFICATION_TYPES: PollNotificationMap = {
[sdkTypes.HMSPollsUpdate.POLL_STOPPED]: HMSNotificationTypes.POLL_STOPPED,
[sdkTypes.HMSPollsUpdate.POLL_STATS_UPDATED]: HMSNotificationTypes.POLL_VOTES_UPDATED,
[sdkTypes.HMSPollsUpdate.POLLS_LIST]: HMSNotificationTypes.POLLS_LIST,
// [sdkTypes.HMSPollsUpdate.POLL_LEADERBOARD_SHARED]: HMSNotificationTypes.POLL_LEADERBOARD_SHARED,
};
3 changes: 0 additions & 3 deletions packages/hms-video-store/src/schema/notification.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export interface HMSReconnectionNotification extends BaseNotification {

export interface HMSPollNotification extends BaseNotification {
type: HMSNotificationTypes.POLL_STARTED | HMSNotificationTypes.POLL_STOPPED | HMSNotificationTypes.POLL_VOTES_UPDATED;
// | HMSNotificationTypes.POLL_LEADERBOARD_SHARED;
data: HMSPoll;
}

Expand Down Expand Up @@ -126,7 +125,6 @@ export enum HMSNotificationTypes {
POLL_STOPPED = 'POLL_STOPPED',
POLL_VOTES_UPDATED = 'POLL_VOTES_UPDATED',
POLLS_LIST = 'POLLS_LIST',
// POLL_LEADERBOARD_SHARED = 'POLL_LEADERBOARD_SHARED',
HAND_RAISE_CHANGED = 'HAND_RAISE_CHANGED',
}

Expand Down Expand Up @@ -159,7 +157,6 @@ export type HMSNotificationMapping<T extends HMSNotificationTypes, C = any> = {
[HMSNotificationTypes.POLL_STOPPED]: HMSPollNotification;
[HMSNotificationTypes.POLL_VOTES_UPDATED]: HMSPollNotification;
[HMSNotificationTypes.POLLS_LIST]: HMSPollNotification;
// [HMSNotificationTypes.POLL_LEADERBOARD_SHARED]: HMSPollNotification;
[HMSNotificationTypes.POLL_CREATED]: HMSPollNotification;
[HMSNotificationTypes.HAND_RAISE_CHANGED]: HMSPeerNotification;
}[T];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ export class InteractivityCenter implements HMSInteractivityCenter {
}
}
});
// To debug: the store only updates the second time this runs (opening the sidepane a second time)
console.log('zzz setting', { pollCopy: pollCopy?.questions });
this.store.setPoll(pollCopy);
}
async getPolls(): Promise<HMSPoll[]> {
Expand Down

0 comments on commit 9eff6c8

Please sign in to comment.