feat: disable auto unsubscribe video based on init flag

100mslive · Jun 20, 2023 · 65bcfad · 65bcfad
1 parent b27c92d
commit 65bcfad
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/packages/hms-video-web/src/connection/subscribe/subscribeConnection.ts b/packages/hms-video-web/src/connection/subscribe/subscribeConnection.ts
@@ -1,9 +1,10 @@
 import EventEmitter from 'eventemitter2';
 import { v4 as uuid } from 'uuid';
 import ISubscribeConnectionObserver from './ISubscribeConnectionObserver';
-import { HMSRemoteStream } from '../../internal';
+import { HMSRemoteStream, HMSSimulcastLayer } from '../../internal';
 import { HMSRemoteAudioTrack } from '../../media/tracks/HMSRemoteAudioTrack';
 import { HMSRemoteVideoTrack } from '../../media/tracks/HMSRemoteVideoTrack';
+import { InitFlags } from '../../signal/init/models';
 import { ISignal } from '../../signal/ISignal';
 import { API_DATA_CHANNEL } from '../../utils/constants';
 import HMSLogger from '../../utils/logger';
@@ -106,7 +107,12 @@ export default class HMSSubscribeConnection extends HMSConnection {
     };
   }
 
-  constructor(signal: ISignal, config: RTCConfiguration, observer: ISubscribeConnectionObserver) {
+  constructor(
+    signal: ISignal,
+    config: RTCConfiguration,
+    private isFlagEnabled: (flag: InitFlags) => boolean,
+    observer: ISubscribeConnectionObserver,
+  ) {
     super(HMSConnectionRole.Subscribe, signal);
     this.observer = observer;
 
@@ -128,6 +134,13 @@ export default class HMSSubscribeConnection extends HMSConnection {
     requestId?: string,
   ): Promise<PreferLayerResponse> {
     const id = uuid();
+    if (message.method === 'prefer-video-track-state') {
+      const disableAutoUnsubscribe = this.isFlagEnabled(InitFlags.FLAG_DISABLE_VIDEO_TRACK_AUTO_UNSUBSCRIBE);
+      if (disableAutoUnsubscribe && message.params.max_spatial_layer === HMSSimulcastLayer.NONE) {
+        HMSLogger.d(this.TAG, 'video auto unsubscribe is disabled, request is ignored');
+        return { id } as PreferLayerResponse;
+      }
+    }
     const request = JSON.stringify({
       id: requestId || id,
       jsonrpc: '2.0',

diff --git a/packages/hms-video-web/src/signal/init/models.ts b/packages/hms-video-web/src/signal/init/models.ts
@@ -41,4 +41,7 @@ export enum InitFlags {
   FLAG_SERVER_SIMULCAST = 'simulcast',
   FLAG_NON_WEBRTC_DISABLE_OFFER = 'nonWebRTCDisableOffer',
   FLAG_PUBLISH_STATS = 'publishStats',
+  FLAG_ON_DEMAND_TRACKS = 'onDemandTracks',
+  // Don't unsubscribe for beam to prevent a/v sync in case of active speaker
+  FLAG_DISABLE_VIDEO_TRACK_AUTO_UNSUBSCRIBE = 'disableVideoTrackAutoUnsubscribe',
 }
diff --git a/packages/hms-video-web/src/transport/index.ts b/packages/hms-video-web/src/transport/index.ts
@@ -794,6 +794,7 @@ export default class HMSTransport implements ITransport {
         this.subscribeConnection = new HMSSubscribeConnection(
           this.signal,
           this.initConfig.rtcConfiguration,
+          this.isFlagEnabled.bind(this),
           this.subscribeConnectionObserver,
         );
       }