fix: frozen stats

100mslive · Mar 5, 2024 · 4ccc77e · 4ccc77e
1 parent eaed700
commit 4ccc77e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/packages/hms-video-store/src/analytics/stats/BaseStatsAnalytics.ts b/packages/hms-video-store/src/analytics/stats/BaseStatsAnalytics.ts
@@ -113,6 +113,10 @@ export abstract class RunningTrackAnalytics {
   }
 
   createSample() {
+    if (this.tempStats.length === 0) {
+      return;
+    }
+
     this.samples.push(this.collateSample());
     this.tempStats.length = 0;
   }

diff --git a/packages/hms-video-store/src/analytics/stats/PublishStatsAnalytics.ts b/packages/hms-video-store/src/analytics/stats/PublishStatsAnalytics.ts
@@ -84,6 +84,13 @@ export class PublishStatsAnalytics extends BaseStatsAnalytics {
       });
     });
 
+    // delete track analytics if track is not present in store and no samples are present
+    this.trackAnalytics.forEach(trackAnalytic => {
+      if (!this.store.hasTrack(trackAnalytic.track) && !(trackAnalytic.samples.length > 0)) {
+        this.trackAnalytics.delete(trackAnalytic.track_id);
+      }
+    });
+
     if (shouldCreateSample) {
       this.trackAnalytics.forEach(trackAnalytic => {
         trackAnalytic.createSample();

diff --git a/packages/hms-video-store/src/analytics/stats/SubscribeStatsAnalytics.ts b/packages/hms-video-store/src/analytics/stats/SubscribeStatsAnalytics.ts
@@ -76,6 +76,13 @@ export class SubscribeStatsAnalytics extends BaseStatsAnalytics {
       }
     });
 
+    // delete track analytics if track is not present in store and no samples are present
+    this.trackAnalytics.forEach(trackAnalytic => {
+      if (!this.store.hasTrack(trackAnalytic.track) && !(trackAnalytic.samples.length > 0)) {
+        this.trackAnalytics.delete(trackAnalytic.track_id);
+      }
+    });
+
     if (shouldCreateSample) {
       this.trackAnalytics.forEach(trackAnalytic => {
         trackAnalytic.createSample();