Skip to content

Commit

Permalink
fix: add null check for role change while updating plugins
Browse files Browse the repository at this point in the history
  • Loading branch information
amar-1995 authored Mar 26, 2024
1 parent fd75519 commit 2660667
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/hms-video-store/src/sdk/store/Store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@ import {
HMSVideoTrack,
} from '../../media/tracks';
import { PolicyParams } from '../../notification-manager';
import HMSLogger from '../../utils/logger';
import { ENV } from '../../utils/support';
import { createUserAgent } from '../../utils/user-agent';
import HMSRoom from '../models/HMSRoom';
import { HMSLocalPeer, HMSPeer, HMSRemotePeer } from '../models/peer';

class Store {
private TAG = '[Store]:';
private room?: HMSRoom;
private knownRoles: KnownRoles = {};
private localPeerId?: string;
Expand Down Expand Up @@ -415,6 +417,10 @@ class Store {
pluginName: keyof PolicyParams['plugins'],
permission: HMSPermissionType,
) => {
if (!this.knownRoles[role]) {
HMSLogger.d(this.TAG, `role ${role} is not present in given roles`, this.knownRoles);
return;
}
const rolePermissions = this.knownRoles[role].permissions;
if (!rolePermissions[pluginName]) {
rolePermissions[pluginName] = [];
Expand Down

0 comments on commit 2660667

Please sign in to comment.