fix: make cleanup private

100mslive · Mar 13, 2024 · 03bc7df · 03bc7df
1 parent 95e6d0c
commit 03bc7df
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/packages/hms-video-store/src/common/PluginUsageTracker.ts b/packages/hms-video-store/src/common/PluginUsageTracker.ts
@@ -19,21 +19,28 @@ class PluginUsageTracker {
     return this.pluginUsage.get(pluginKey);
   };
 
-  updatePluginUsage = (event: AnalyticsEvent, sessionID: string) => {
+  updatePluginUsageData = (event: AnalyticsEvent, sessionID: string) => {
+    // Sent on leave, after krisp usage is sent
+    if (event.name === 'subscriber.stats') {
+      this.cleanup(sessionID);
+      return;
+    }
+
     const name = event.properties.plugin_name;
     const pluginKey = `${sessionID}-${name}`;
-
     if (event.name === 'mediaPlugin.added') {
       const addedAt = event.properties.added_at;
       this.pluginLastAddedAt.set(pluginKey, addedAt);
     } else if (event.name === 'mediaPlugin.stats') {
       const duration = event.properties.duration;
-      this.pluginUsage.set(pluginKey, (this.pluginUsage.get(pluginKey) || 0) + duration * 1000);
-      this.pluginLastAddedAt.delete(pluginKey);
+      if (duration) {
+        this.pluginUsage.set(pluginKey, (this.pluginUsage.get(pluginKey) || 0) + duration * 1000);
+        this.pluginLastAddedAt.delete(pluginKey);
+      }
     }
   };
 
-  cleanup = (sessionID: string) => {
+  private cleanup = (sessionID: string) => {
     for (const key of this.pluginUsage.keys()) {
       if (sessionID.length && key.includes(sessionID)) {
         this.pluginUsage.delete(key);

diff --git a/packages/hms-video-store/src/sdk/index.ts b/packages/hms-video-store/src/sdk/index.ts
@@ -573,7 +573,7 @@ export class HMSSdk implements HMSInterface {
     }
     HMSLogger.timeEnd(`join-room-${roomId}`);
     const sessionID = this.store.getRoom()?.sessionId || '';
-    this.eventBus.analytics.subscribe(e => pluginUsageTracker.updatePluginUsage(e, sessionID));
+    this.eventBus.analytics.subscribe(e => pluginUsageTracker.updatePluginUsageData(e, sessionID));
   }
 
   private stringifyMetadata(config: HMSConfig) {
@@ -585,8 +585,6 @@ export class HMSSdk implements HMSInterface {
   }
 
   private cleanup() {
-    const sessionID = this.store.getRoom()?.sessionId || '';
-    pluginUsageTracker.cleanup(sessionID);
     this.cleanDeviceManagers();
     this.eventBus.analytics.unsubscribe(this.sendAnalyticsEvent);
     this.analyticsTimer.cleanup();