Skip to content

Commit

Permalink
Merge pull request #2248 from 100mslive/qa
Browse files Browse the repository at this point in the history
Release PR
  • Loading branch information
KaustubhKumar05 authored Jun 10, 2024
2 parents 1166413 + 7a81d1e commit 655b632
Show file tree
Hide file tree
Showing 28 changed files with 553 additions and 91 deletions.
24 changes: 17 additions & 7 deletions components/Tabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React, { PropsWithChildren, useCallback, useEffect, useState } from 'reac

/**
*
* <Tabs items={['Node.js','Python']}>
* <Tabs items={['Node.js','Python']} isSelector={true}>
*
* <Tab id={1}>
* Code
Expand All @@ -13,15 +13,16 @@ import React, { PropsWithChildren, useCallback, useEffect, useState } from 'reac
/**
* Just because Compound Component React Pattern
* Wasn't Working in MDX (children code not getting parsed)
* So Took this Vanilla API approahc WORKS.
* So Took this Vanilla API approach WORKS.
*/

interface TabsProps {
items: string[];
id: string;
isSelector?: boolean;
}

export const Tabs: React.FC<TabsProps> = ({ items, id }) => {
export const Tabs: React.FC<TabsProps> = ({ items, id, isSelector = false }) => {
const [tab, setTab] = useState(0);
const [currentPlatform, setCurrentPlatform] = useState('');

Expand Down Expand Up @@ -60,7 +61,7 @@ export const Tabs: React.FC<TabsProps> = ({ items, id }) => {
);

// For setting value on future visits / reload
React.useEffect(() => {
useEffect(() => {
const tabSelection = JSON.parse(localStorage.getItem('tabSelection') || '{}');
const storedValue = items.indexOf(tabSelection[currentPlatform]);
const idx = storedValue !== -1 ? storedValue : 0;
Expand All @@ -72,7 +73,13 @@ export const Tabs: React.FC<TabsProps> = ({ items, id }) => {
<div
style={{
borderBottom: '0.5px solid var(--docs_border_strong)',
marginTop: 'var(--docs_spacing_2)'
marginTop: 'var(--docs_spacing_2)',
width: 'max-content',
backgroundColor: isSelector ? 'var(--surface_default)' : 'transparent',
borderRadius: isSelector ? '12px' : '0',
padding: isSelector ? '8px' : '0',
display: 'flex',
gap: '1rem'
}}>
{items.map((el, i) => (
<button
Expand All @@ -86,8 +93,11 @@ export const Tabs: React.FC<TabsProps> = ({ items, id }) => {
outline: 'none',
cursor: 'pointer',
border: 'none',
marginRight: '1rem',
borderBottom: tab === i ? '2px solid var(--gray12)' : 'none'
borderBottom: tab === i && !isSelector ? '2px solid var(--gray12)' : 'none',
padding: isSelector ? '5px 12px' : '0',
borderRadius: isSelector ? '4px' : '0',
backgroundColor:
tab === i && isSelector ? 'var(--selector_blue)' : 'transparent'
}}
key={el}
id={`${id}-button-${i}`}>
Expand Down
90 changes: 84 additions & 6 deletions docs/android/v2/how-to-guides/install-the-sdk/size.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,88 @@
title: SDK Size Impact
nav: 3.4
---
There are several libraries provided for 100ms-android. Generally the SDK core is required for doing anything with meetings and you can add each individual library if you want it.

Each library has its own size impact that can vary been ABIs (x86, arm64-v8a etc), the table below lists them all.

These sizes are calculated by building release versions of ABI split APKs from the same project, and then subtracting the size of the same project without any 100ms libraries added.

You can take a look at the reference project [here](https://github.com/100mslive/Android-Size-Reference-App/)

These are accurate for sdk version `2.9.59` and room-kit version `1.2.13`.

## Increase in Android APK size:

| Phone Architecture | Room Kit |
| --------------------------------- | --------- |
| (armeabi-v7) | **10.9MB** |
| (arm64-v8a) **(most common one)** | **11.8MB** |
| (x86_64) | **12.7MB** |
| (x86) | **12.5MB** |

The base `room-kit` already includes the following libraries:

- `android-sdk`
- `video-view`
- `hls-player`
- `video-filters`

To add, for instance `noise-cancellation`, take a look at the table below.

## SDK and each add on library
> Note: Most SDK add on libraries cannot be used without the sdk.
| Phone Architecture | Android Sdk |
| --------------------------------- | --------- |
| (armeabi-v7) | **5.7MB** |
| (arm64-v8a) **(most common one)** | **6.7MB** |
| (x86_64) | **7.6MB** |
| (x86) | **7.3MB** |

| Phone Architecture | Video View |
| --------------------------------- | --------- |
| (armeabi-v7) | **8.5KB** |
| (arm64-v8a) **(most common one)** | **8.5KB** |
| (x86_64) | **8.5KB** |
| (x86) | **8.5KB** |


| Phone Architecture | Virtual Background |
| --------------------------------- | --------- |
| (armeabi-v7) | **12.9MB** |
| (arm64-v8a) **(most common one)** | **15.4MB** |
| (x86_64) | **4.0MB** |
| (x86) | **4.0MB** |


| Phone Architecture | Video Filters |
| --------------------------------- | --------- |
| (armeabi-v7) | **24.9KB** |
| (arm64-v8a) **(most common one)** | **20.6KB** |
| (x86_64) | **21.0KB** |
| (x86) | **20.6KB** |


| Phone Architecture | Noise Cancellation |
| --------------------------------- | --------- |
| (armeabi-v7) | **5.6MB** |
| (arm64-v8a) **(most common one)** | **5.6MB** |
| (x86_64) | **5.6MB** |
| (x86) | **5.6MB** |


| Phone Architecture | Hls Player Stats |
| --------------------------------- | --------- |
| (armeabi-v7) | **443.2KB** |
| (arm64-v8a) **(most common one)** | **443.2KB** |
| (x86_64) | **443.2KB** |
| (x86) | **443.2KB** |


| Phone Architecture | Hls Player |
| --------------------------------- | --------- |
| (armeabi-v7) | **939.4KB** |
| (arm64-v8a) **(most common one)** | **939.4KB** |
| (x86_64) | **939.4KB** |
| (x86) | **939.4KB** |

| Increase APK size | |
| --------------------------------- | --------- |
| (armeabi-v7) | **5.8MB** |
| (arm64-v8a) **(most common one)** | **6.4MB** |
| (x86_64) | **7.1MB** |
| (x86) | **7.2MB** |
Original file line number Diff line number Diff line change
Expand Up @@ -176,3 +176,9 @@ nav: '2.8'
### TRACK_UNMUTED

**TRACK_UNMUTED** = `"TRACK_UNMUTED"`

---

### TRANSCRIPTION_STATE_UPDATED

**TRANSCRIPTION_STATE_UPDATED** = `"TRANSCRIPTION_STATE_UPDATED"`
Loading

0 comments on commit 655b632

Please sign in to comment.