v2 signature decoding validates EIP-6492 signatures #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the overall idea is fine. Someone consuming these parts should perform the deployment first before attempting to execute them onchain. My only feedback is that 6492 signature parts shouldn’t return core.SignerSignature but instead something like core.Signer6492Signature or similar, and the returned struct should contain both the signature and the code to deploy the wallet. It could include either: a) The signature and deploy code, both decoded |
Agusx1211
reviewed
Dec 3, 2024
Agusx1211
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows EIP6492 signature to be validated as a dynamic signature. Inner EIP1271 is then stripped from the signature and returned for wallet recovery.
Note: EIP6492 is not valid as a sequence wallet signature part. Deployment transactions are typically prepended to the bundle to allow the normal signature to validate. As this section of code is for config recovery and not validation I think using EIP6492 to include the deployment is valid usage. Returning the inner EIP1271 signature allows validation to proceed as normal.