Addressing State being consistent in value from the first check (#90) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md - change variable appState name to usernameState to reflect the value of the variable. * Update README.md - update appState variable name to usernameState for the whole read and write section * Made changes to State to cache value when it is first retrieved. Added a test to ensure that state value is consistent from when it is first checked * Made additions to testStateClosureCachesValueOnGet to account for async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to State to cache value when it is first retrieved. Added a test to ensure that state value is consistent from when it is first checked
Made additions to testStateClosureCachesValueOnGet to account for async