docs: addes subject and audit for the travel-plan project #2282
Conversation
There was a problem hiding this comment.
I left some comments about changes that I feel are required to make the subject clearer.
Additionally, there are some minor grammar mistakes. I would recommend to use a plugin for grammar check in VSCode (or the editor you're using) or some CLI tools such as write-good or proselint
There was a problem hiding this comment.
I left some comments inline.
Some old conversations have not been addressed: please, add a reaction to the conversation when you address them or add a comment about why you don't think we should implement the suggested changes.
There are quite some comments about capitalization - I left one comment per line to help keep track of which lines should be capitalized.
There was a problem hiding this comment.
I left some comments in line to improve the clarity of some parts of the subject and audit.
I found two audit questions that ask for specific features that are not clearly defined in the subject (API Gateway and Logging system).
Additionally, it is mentioned to use the least privilege principle as a security measure and to use role-based access controls: isn't this supposed to be only for admin? Is it expected to have more than one level of access to the platform? This could create confusion in the audit phase of the project.
There was a problem hiding this comment.
I have added two minor change requests inline.
@zanninso it is mentioned to use the least privilege principle as a security measure and to use role-based access controls: isn't this supposed to be only for admin? Is it expected to have more than one level of access to the platform? This could create confusion in the audit phase of the project.
for this part of the project they will have just the admin role but in the final project they have to add more roles, it's already explained in subject. i don;t see that will make any confusion |
No description provided.