Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-2277 Create new subject and audit for play-with-containers-py based on JS version #2274

Closed
wants to merge 4 commits into from
Closed

CON-2277 Create new subject and audit for play-with-containers-py based on JS version #2274

wants to merge 4 commits into from

Conversation

nprimo
Copy link
Contributor

@nprimo nprimo commented Oct 31, 2023

No description provided.

MSilva95
MSilva95 requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the two sentences that in my opinion will cause some misunderstanding for students, and one of the questions is not mentioned in the readme so I'm not sure if it should exist in the audit

subjects/devops/play-with-containers-py/audit/README.md Show resolved Hide resolved
subjects/devops/play-with-containers-py/audit/README.md Outdated Show resolved Hide resolved
subjects/devops/play-with-containers-py/audit/README.md Outdated Show resolved Hide resolved
subjects/devops/play-with-containers-py/audit/README.md Outdated Show resolved Hide resolved
@nprimo nprimo requested a review from MSilva95 November 2, 2023 09:50
@nprimo nprimo self-assigned this Nov 6, 2023
@nprimo nprimo mentioned this pull request Nov 6, 2023
Merged
@nprimo
Copy link
Contributor Author

nprimo commented Nov 6, 2023

I move this changes to this PR

MSilva95
MSilva95 reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will close this as it was moved, the changes are corrected in the other pr!

@MSilva95 MSilva95 closed this Nov 8, 2023
@HarryVasanth HarryVasanth deleted the CON-2277-add-subject-and-audit-for-play-with-containers-py branch November 6, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSilva95 MSilva95 MSilva95 requested changes

Assignees

@nprimo nprimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nprimo @MSilva95