Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-2274: adding a new file for code editor to use in the rust-piscine #2267

Merged
merged 2 commits into from
Nov 14, 2023
Merged

CON-2274: adding a new file for code editor to use in the rust-piscine #2267

merged 2 commits into from
Nov 14, 2023

Conversation

MSilva95
Copy link
Member

No description provided.

@MSilva95 MSilva95 requested a review from LEEDASILVA October 25, 2023 12:04
@MSilva95 MSilva95 marked this pull request as ready for review October 25, 2023 12:04
@MSilva95 MSilva95 self-assigned this Oct 25, 2023
LEEDASILVA
LEEDASILVA approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@LEEDASILVA LEEDASILVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you caught some inconsistencies on the READMEs'. Nice !

Checked the list of refs that we added the codeEditor.providedFiles and it matches the files changed here. 👍

@MSilva95 MSilva95 merged commit 166a109 into master Nov 14, 2023
2 checks passed
@MSilva95 MSilva95 deleted the CON-2274-implement-the-rust-files-at-the-same-level-as-the-readme branch November 14, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LEEDASILVA LEEDASILVA LEEDASILVA approved these changes

Assignees

@MSilva95 MSilva95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSilva95 @LEEDASILVA