Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Con 1813 markdown chaikin raid for java piscine #2177

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

zanninso
Copy link
Contributor

@zanninso zanninso commented Sep 8, 2023

No description provided.

@zanninso zanninso assigned zainabdnaya and zanninso and unassigned zanninso Mar 5, 2024
@zanninso zanninso requested a review from nprimo March 5, 2024 01:06
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comment inline + the 2 files needs to be formatted using prettier

subjects/java/raids/Jaikin/README.md Show resolved Hide resolved
subjects/java/raids/Jaikin/README.md Outdated Show resolved Hide resolved
subjects/java/raids/Jaikin/README.md Show resolved Hide resolved
subjects/java/raids/Jaikin/README.md Show resolved Hide resolved
subjects/java/raids/Jaikin/audit/README.md Outdated Show resolved Hide resolved
@zanninso zanninso requested a review from nprimo March 7, 2024 00:18
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You can resolve the remaining conversation - I have added more context to justify my previous comment: I am sure students can understand the required output type by reading all the information provided.

@zanninso zanninso merged commit 24c7f9e into master Mar 7, 2024
2 checks passed
@zanninso zanninso deleted the CON-1813-MARKDOWN-chaikin-raid-for-java-piscine branch March 7, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants