Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues in public #1527

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Issues in public #1527

merged 4 commits into from
Oct 20, 2022

Conversation

MSilva95
Copy link
Member

fix(ascii-art): fixing the way to use the flag on the optional projects

This was linked to issues Oct 19, 2022
ascii-art-color subject #1510
Closed
satori/uuid is unmaintained and vulnurable #1518
Closed
ascii-art-color #1519
Closed
@MSilva95 MSilva95 linked an issue Oct 19, 2022 that may be closed by this pull request
graphql subject #1512
Closed
@MSilva95 MSilva95 requested a review from nprimo October 20, 2022 13:32
nprimo
nprimo suggested changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few lines with some autogenerated texts from git that should be removed.

subjects/ascii-art/output/audit.md Outdated Show resolved Hide resolved
subjects/ascii-art/output/audit.md Outdated Show resolved Hide resolved
subjects/ascii-art/output/audit.md Outdated Show resolved Hide resolved
subjects/ascii-art/output/audit.md Outdated Show resolved Hide resolved
@MSilva95 MSilva95 requested a review from nprimo October 20, 2022 14:46
nprimo
nprimo approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good 🚀

@MSilva95 MSilva95 merged commit 943ce12 into master Oct 20, 2022
@MSilva95 MSilva95 deleted the DEV-3789-improving-subjects branch October 20, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nprimo nprimo nprimo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ascii-art-color satori/uuid is unmaintained and vulnurable graphql subject ascii-art-color subject
2 participants
@MSilva95 @nprimo