Made arrayElement<T>(start, end) more elegant and minor fixes (ciesla…

…rmichal#837)

include/faker-cxx/helper.h

@@ -49,7 +49,7 @@ T arrayElement(const std::array<T, N>& data)
     return data[index];
 }
 
-template <typename It>
+template <std::input_iterator It>
 auto arrayElement(It start, It end) -> decltype(*::std::declval<It>())
 {
     auto size = static_cast<size_t>(end - start);
@@ -61,7 +61,7 @@ auto arrayElement(It start, It end) -> decltype(*::std::declval<It>())
 
     const std::integral auto index = number::integer<size_t>(size - 1);
 
-    return start[index];
+    return *(start + static_cast<std::iter_difference_t<It>>(index));
 }
 
 /**

src/modules/datatype.cpp

@@ -13,21 +13,19 @@ bool boolean()
 
 bool boolean(double probability)
 {
-    if (probability != nan(""))
+    if (!std::isnan(probability))
     {
-        double prob = probability;
-
-        if (prob <= double(0.))
+        if (probability <= double(0))
         {
             return false;
         }
 
-        if (prob >= double(1.))
+        if (probability >= double(1))
         {
             return true;
         }
 
-        return double(number::decimal(0., 1.)) < prob;
+        return number::decimal(0., 1.) < probability;
     }
 
     return number::decimal(0., 1.) < 0.5;